Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making actions instance methods on Player for cleaner Ruby syntax #501

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Making actions instance methods on Player for cleaner Ruby syntax #501

merged 2 commits into from
Jan 16, 2024

Conversation

radar
Copy link
Owner

@radar radar commented Jan 15, 2024

Before

action = Magic::Actions::ActivateAbility.new(player: p1, permanent: island, ability: island.activated_abilities.first)

After

p1.activate_ability(ability: island.activated_abilities.first)

Abilities are now tied to the permanent they're from. IOW, going from ability -> permanent now rather than permanent -> abilities.

@radar radar merged commit 7070d9d into master Jan 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@radar